-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate SettingsWallet
page to TypeScript
#34716
Conversation
Lint check is failing, please change the title to |
SettingsWallet
SettingsWallet
page to TypeScript
@situchan Do you want me to fix it here? |
No, can you create follow-up PR if possible? |
Sure, I'll raise follow-up PR in that issue and get it merged today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tienifr please let me know when that PR is ready and I'll review it
@tienifr please merge main. Crash is fixed now |
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
@situchan I added screenshots for all platforms. We're good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we tested using mock data.
Not sure if QA team is able to test this PR properly since they might not have physical card.
They have. They already tested all other card/wallet PRs. |
Hey @tienifr, would you mind merging |
Actually nevermind, merging main on Friday was probably good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling to test some of this on dev. Let's get this to staging for QA verification
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.44-0 🚀
|
@Julesssss @situchan QA team does not have physical card or not activated cards. Is this PR internal? |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
const virtualCard = _.find(domainCards, (card) => card.isVirtual) || {}; | ||
const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard) || ''; | ||
const virtualCard = domainCards?.find((card) => card.isVirtual); | ||
const virtualCardError = ErrorUtils.getLatestErrorMessage(virtualCard?.errors ?? {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the parameter of getLatestErrorMessage
from virtualCard
to virtualCard?.errors ?? {}
causes an issue where the server error does not display. This happens because the updated parameter always returns an empty string more context on this Issue #49010 (comment).
Details
TS migration
SettingsWallet
.Fixed Issues
$ #32003
PROPOSAL:
Tests
ExpensifyCardPage
/settings/wallet/card/Expensify
MM/YYYY
ReportVirtualCardFraudPage
ReportCardLostPage
AddDebitCardPage
/settings/wallet/add-debit-card
ActivatePhysicalCardPage
Precondition: Have an unactivated card.
/settings/wallet/card/Expensify/activate
That didn't match the last four digits on the card. Please try again.
TransferBalancePage
,ChooseTransferAccountPage
settings/wallet/transfer-balance
Which account?
and Fee shows$0.25
Which account?
and Fee shows$0.00
Auth TransferWalletBalance returned an error
Offline tests
NA
QA Steps
ExpensifyCardPage
/settings/wallet/card/Expensify
MM/YYYY
ReportVirtualCardFraudPage
ReportCardLostPage
AddDebitCardPage
/settings/wallet/add-debit-card
ActivatePhysicalCardPage
Precondition: Have an unactivated physical card.
/settings/wallet/card/Expensify/activate
TransferBalancePage
,ChooseTransferAccountPage
settings/wallet/transfer-balance
Which account?
and Fee shows 1.5% of current balanceWhich account?
and Fee shows$0.00
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-02-25.at.19.42.19-compressed.mov
Screen.Recording.2024-02-25.at.19.41.42-compressed.mov
Screen.Recording.2024-02-25.at.19.41.05-compressed.mov
Android: mWeb Chrome
Screen.Recording.2024-02-25.at.19.46.20-compressed.mov
Screen.Recording.2024-02-25.at.19.45.23-compressed.mov
Screen.Recording.2024-02-25.at.19.44.30-compressed.mov
iOS: Native
Screen.Recording.2024-02-25.at.19.25.42-compressed.mov
Screen.Recording.2024-02-25.at.19.32.22-compressed.mov
Screen.Recording.2024-02-25.at.19.33.17-compressed.mov
Screen.Recording.2024-02-25.at.19.34.24-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-02-25.at.19.38.37-compressed.mov
Screen.Recording.2024-02-25.at.19.37.31-compressed.mov
Screen.Recording.2024-02-25.at.19.36.51-compressed.mov
MacOS: Chrome / Safari
ExpensifyCardPage
,ReportVirtualCardFraudPage
,ReportCardLostPage
Screen.Recording.2024-01-19.at.15.17.20-compressed.mov
Screen.Recording.2024-01-19.at.15.23.20-compressed.mov
AddDebitCardPage
Screen.Recording.2024-01-19.at.16.19.45-compressed.mov
TransferBalancePage
,ChooseTransferAccountPage
Screen.Recording.2024-02-25.at.19.17.20-compressed.mov
MacOS: Desktop
ExpensifyCardPage
,ReportVirtualCardFraudPage
,ReportCardLostPage
Screen.Recording.2024-01-19.at.15.17.20-compressed.mov
Screen.Recording.2024-01-19.at.15.23.20-compressed.mov
AddDebitCardPage
Screen.Recording.2024-01-19.at.16.19.45-compressed.mov
TransferBalancePage
,ChooseTransferAccountPage
Screen.Recording.2024-02-25.at.19.17.20-compressed.mov